ROX-20541: Temporarily exclude kernels 6.6 from build #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue has been fixed and the TODO statement is misleading here.
|
Skipping CI for Draft Pull Request. |
Molter73
approved these changes
Oct 30, 2023
kernel-modules/BLOCKLIST
Outdated
| ~6\.[3-9]\.\d+.* ~2\.[2-5]\.\d+(?:-rc\d+)? | ||
| # TODO(ROX-20541) - 6.6 kernel compilation errors | ||
| 6.6.* * |
There was a problem hiding this comment.
You don't need the second parameter as a *, since the script that processes this file assumes all missing parts are *. https://github.com/stackrox/collector/blob/24b43e3f04594741fc92957662a4eae41bc53fdb/kernel-modules/build/apply-blocklist.py#L41C8-L41C8
There was a problem hiding this comment.
And it is explained in the comment header... Removed it !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A patch was introduced to solve build issues on earlier RC versions of 6.6, which is now causing
build issues. It has been mostly reverted upstream.
Block temporarily those kernels while we work on pulling upstream.
Testing
This does not touch the Collector code, we just want to make the drivers build happy.