Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes dev driver builds by copying driver config #1397

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fixes dev driver builds by copying driver config #1397

merged 1 commit into from
Oct 31, 2023

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Oct 31, 2023

Description

From a clean state, the driver config is not copied into the source tree like it is for CI builds. This PR simply copied the file over.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed\

Tested locally. Should not affect CI.

@Stringy Stringy requested a review from a team as a code owner October 31, 2023 11:10
Molter73
Molter73 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stringy Stringy merged commit 053f6e6 into master Oct 31, 2023
40 checks passed
@Stringy Stringy deleted the giles/fix-dev-driver-builds branch October 31, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stringy @Molter73