Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log asserts #1399

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Log asserts #1399

merged 1 commit into from
Nov 21, 2023

Conversation

erthalion
Copy link
Contributor

@erthalion erthalion commented Nov 1, 2023

Description

Customize Falco to log ASSERTS if configured.

Checklist

  • Investigated and inspected CI test results
    - [ ] Updated documentation accordingly

Automated testing
- [ ] Added unit tests
- [ ] Added integration tests
- [ ] Added regression tests

Testing Performed

Local testing, the result looks like this:

[ERROR   2023/11/01 14:13:55] (Logging.cpp:105) ASSERTION !(evt->m_fdinfo->is_unix_socket() || evt->m_fdinfo->is_ipv4_socket()) at /tmp/collector/falcosecurity-libs/userspace/libsinsp/parsers.cpp:3092

@erthalion erthalion requested a review from a team as a code owner November 1, 2023 14:20
@erthalion erthalion force-pushed the feature/assert-logging-main branch 2 times, most recently from 89d4ab4 to df763bf Compare November 9, 2023 10:52
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Turn on Falco assert logging for all build types. Make _DEBUG dependent
on the Debug build type, it would impact asserts logic when asserts
logging is disabled.
@erthalion erthalion merged commit 6d3c382 into master Nov 21, 2023
45 of 46 checks passed
@erthalion erthalion deleted the feature/assert-logging-main branch November 21, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants