ROX-20235: build collector-full on Konflux #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: red-hat-trusted-app-pipeline <[email protected]>
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
…nto tm/rhtap-onboarding
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
Co-authored-by: red-hat-trusted-app-pipeline <[email protected]>
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
…nto tm/rhtap-onboarding
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
Co-authored-by: red-hat-trusted-app-pipeline <123456+red-hat-trusted-app-pipeline[bot]@users.noreply.github.com>
Co-authored-by: Misha Sugakov <[email protected]>
Co-authored-by: Misha Sugakov <[email protected]>
Co-authored-by: Misha Sugakov <[email protected]>
This reverts commit b1da270.
msugakov
reviewed
Feb 14, 2024
msugakov
reviewed
Feb 14, 2024
Co-authored-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: Misha Sugakov <[email protected]>
msugakov
reviewed
Feb 15, 2024
msugakov
reviewed
Feb 15, 2024
msugakov
approved these changes
Feb 16, 2024
.tekton/collector-pull-request.yaml
Outdated
| "$(workspaces.source.path)/source" | ||
| "$(workspaces.source.path)/source/collector/container/scripts/download-support-package.sh" \ | ||
| "$(workspaces.source.path)/source/staging" \ | ||
| "$(cat $(workspaces.source.path)/source/kernel-modules/MODULE_VERSION)" |
There was a problem hiding this comment.
Cosmetics:
Suggested change
| "$(cat $(workspaces.source.path)/source/kernel-modules/MODULE_VERSION)" | |
| "$(cat "$(workspaces.source.path)/source/kernel-modules/MODULE_VERSION")" |
.tekton/collector-push.yaml
Outdated
| "$(workspaces.source.path)/source" | ||
| "$(workspaces.source.path)/source/collector/container/scripts/download-support-package.sh" \ | ||
| "$(workspaces.source.path)/source/staging" \ | ||
| "$(cat $(workspaces.source.path)/source/kernel-modules/MODULE_VERSION)" |
There was a problem hiding this comment.
Suggested change
| "$(cat $(workspaces.source.path)/source/kernel-modules/MODULE_VERSION)" | |
| "$(cat "$(workspaces.source.path)/source/kernel-modules/MODULE_VERSION")" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the collector-full builds to Konflux.
The difference to
collector-slimbuilds is addition of kernel modules downloaded from support packages and from thedriver-buildsimage.Planned follow-ups:
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
I tested the new image in the collector integration tests.
StackRox E2E tests were validated in stackrox/stackrox#9614.