Run multiarch builds natively rather than via QEMU #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringy
force-pushed
the
giles/multiarch-native-builds
branch
from
dfd2e05
to
165afea
Compare
Stringy
force-pushed
the
giles/multiarch-native-builds
branch
from
23b5bd2
to
8fd91f3
Compare
This change makes it so collector compiles and runs using upstream Falco directly. There are a few minor tweaks still required in Falco itself, but they are things that are either on their way to upstream or should be real ease to upstream. List of changes needed for vanilla to be compatible: - Remove sinsp-wrapper and link directly to sinsp. - Remove sinsp_filter_check_iface in favor of sinsp_filter_check. - Use MINIMAL_BUILD instead of MINIMAL_BUILD_WITH_EBPF. - Remove g_bpf_drop_syscalls. - eBPF probe is compiled directly instead of via cmake.
Add uthash submodule
Fix locations for BTF symbols
Configure build process to enable socket only fd optimization
As an optimization, use only a certain subset of cgroup subsystems.
It could be expesinve to pass large cgroup names from the kernel to user space.
Needed to include the arm64 builder image
One side effect of [1] is that procexit is not included by default any more if ppm_sc is not empty. Which means to continue receiving procexit we need to explicitly add it into the list of interesting events. procexit is essential for memory management, as its handlers perform threadinfo cache clean up. [1]: falcosecurity/libs#1001
Turn on Falco assert logging for all build types. Make _DEBUG dependent on the Debug build type, it would impact asserts logic when asserts logging is disabled.
If CMAKE_BUILD_TYPE is debug, the condition for stripping the binary is not invoked, and the resulting exit code is 1, stopping the build. Ignore this branch and return exit code 0.
This change makes it so collector compiles and runs using upstream Falco directly. There are a few minor tweaks still required in Falco itself, but they are things that are either on their way to upstream or should be real ease to upstream. List of changes needed for vanilla to be compatible: - Remove sinsp-wrapper and link directly to sinsp. - Remove sinsp_filter_check_iface in favor of sinsp_filter_check. - Use MINIMAL_BUILD instead of MINIMAL_BUILD_WITH_EBPF. - Remove g_bpf_drop_syscalls. - eBPF probe is compiled directly instead of via cmake.
Add uthash submodule
Add uthash submodule
…mplification and clarity
Stringy
force-pushed
the
giles/ppc64le-core-bpf-testing
branch
from
5528455
to
dc521ae
Compare
This change makes it so collector compiles and runs using upstream Falco directly. There are a few minor tweaks still required in Falco itself, but they are things that are either on their way to upstream or should be real ease to upstream. List of changes needed for vanilla to be compatible: - Remove sinsp-wrapper and link directly to sinsp. - Remove sinsp_filter_check_iface in favor of sinsp_filter_check. - Use MINIMAL_BUILD instead of MINIMAL_BUILD_WITH_EBPF. - Remove g_bpf_drop_syscalls. - eBPF probe is compiled directly instead of via cmake.
Add uthash submodule
Add uthash submodule
Stringy
force-pushed
the
giles/multiarch-native-builds
branch
from
8fd91f3
to
fcb1444
Compare
Base automatically changed from
giles/ppc64le-core-bpf-testing
to
mauro/use-falco-upstream
January 3, 2024 13:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to add ppc64le and arm64 to the existing native builds provided for s390x in #1448