-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runs tests based on capabilities of the image #1483
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
f6bf126
to
22d06e6
Compare
Why are P and Z not using |
ah I believe it is because I am a little bit blind 😅 |
A strange error occurred https://github.com/stackrox/collector/actions/runs/7613242274/job/20732912611?pr=1483#step:15:41 But once this is solved, I suggest to remove the |
ea5eb67
to
4f78ec4
Compare
Description
Instead of running the tests based on labels provided in a PR, we can inspect the built image and check which architectures it supports and test based on that information. It effectively decouples the tests from the builds, and makes it more flexible / robust.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.