Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runs tests based on capabilities of the image #1483

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Jan 4, 2024

Description

Instead of running the tests based on labels provided in a PR, we can inspect the built image and check which architectures it supports and test based on that information. It effectively decouples the tests from the builds, and makes it more flexible / robust.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

Copy link

openshift-ci bot commented Jan 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Stringy Stringy added the run-multiarch-builds Run steps for non-x86 archs. label Jan 4, 2024
@Stringy Stringy mentioned this pull request Jan 4, 2024
5 tasks
@Stringy Stringy marked this pull request as ready for review January 4, 2024 13:47
@Stringy Stringy requested a review from a team as a code owner January 4, 2024 13:47
@Stringy Stringy force-pushed the giles/gha-decouple-tests-from-builds branch from f6bf126 to 22d06e6 Compare January 19, 2024 14:46
@ovalenti
Copy link
Contributor

Why are P and Z not using identify-image-platforms.outputs.supported_archs instead of the multiarch label ?

@Stringy
Copy link
Collaborator Author

Stringy commented Jan 22, 2024

ah I believe it is because I am a little bit blind 😅

@ovalenti
Copy link
Contributor

A strange error occurred https://github.com/stackrox/collector/actions/runs/7613242274/job/20732912611?pr=1483#step:15:41

But once this is solved, I suggest to remove the run-multiarch-build to see whether the tests are skipped.

@Stringy Stringy force-pushed the giles/gha-decouple-tests-from-builds branch from ea5eb67 to 4f78ec4 Compare February 6, 2024 14:35
@Stringy Stringy removed the run-multiarch-builds Run steps for non-x86 archs. label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants