Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create s390x build VMs when theyre needed #1506

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Jan 17, 2024

Description

s390x build VMs were being created always, even when multi-arch builds were not requested as part of a PR. This simple makes sure that VM creation abides by the labels.

@Stringy Stringy requested a review from a team as a code owner January 17, 2024 10:40
@Stringy Stringy force-pushed the giles/fix-s390x-pr-vm-creation branch from 7afabf2 to d06a398 Compare January 17, 2024 13:38
@Stringy Stringy force-pushed the giles/fix-s390x-pr-vm-creation branch from a6a8f6e to 799f020 Compare January 19, 2024 13:52
Copy link
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks !

The CI failure is on rhel/amd64, so it does not seem related.

Maybe running the PR with the multiarch label would also check that the VM is successfully created.

@Stringy Stringy added the run-multiarch-builds Run steps for non-x86 archs. label Jan 22, 2024
@Stringy Stringy merged commit c8fa07a into master Jan 23, 2024
101 of 104 checks passed
@Stringy Stringy deleted the giles/fix-s390x-pr-vm-creation branch January 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-multiarch-builds Run steps for non-x86 archs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants