Set default log level in tests to debug #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringy
force-pushed
the
giles/debug-logging-in-tests
branch
4 times, most recently
from
abb1994
to
7e532b1
Compare
Stringy
force-pushed
the
giles/debug-logging-in-tests
branch
from
ad3c2e9
to
605cb4c
Compare
|
@Stringy, this is probably part of the goal, but just to make sure : the size of the produced logs for core_bpf is very large. Do we have the right level applied here ? |
|
Yes, I think it's unavoidable currently. The majority of logs that come from core-bpf are Falco's own debug logging in the modern bpf engine. We could perhaps change them to |
|
It is fine, I merely wanted to make sure that the size had been noticed and was expected 👍 |
ovalenti
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During test containerization, the default log level was erroneously set to INFO. This switches it back to debug.