Ensure Collector is always cleaned up #1548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes Collector is either expected to fail or can fail during test setup or healthchecks. We want to retain any logs from the collector container, even in these cases.
The clean up function has been changed to unconditionally clean up Collector:
--rm
so we can get the logs. For this reason, all the collector manager functions cope with a container that is not running (which makes the check in the clean up function redundant)Checklist
Testing Performed
CI primarily. Not able to strictly reproduce the problem seen here but existence of logs in the right places should be enough