Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Collector is always cleaned up #1548

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Feb 12, 2024

Description

Sometimes Collector is either expected to fail or can fail during test setup or healthchecks. We want to retain any logs from the collector container, even in these cases.

The clean up function has been changed to unconditionally clean up Collector:

  • Collector is not run with --rm so we can get the logs. For this reason, all the collector manager functions cope with a container that is not running (which makes the check in the clean up function redundant)
  • The base class should be more thorough to ensure that all resources are cleaned up

Checklist

  • Investigated and inspected CI test results

Testing Performed

CI primarily. Not able to strictly reproduce the problem seen here but existence of logs in the right places should be enough

@Stringy Stringy requested a review from a team as a code owner February 12, 2024 13:17
@Stringy Stringy merged commit c60e7f9 into master Feb 12, 2024
48 checks passed
@Stringy Stringy deleted the giles/ensure-logs-always-written branch February 12, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants