[tests] Use a specific logs entry to detect Collector readiness #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be done with a message over GRPC? or identification of the first message that indicates the probe has been loaded successfully? |
After a more thorough read of the code, it turns out that our readiness service already guarantees that absolutely everything is ready when it turns to green. As a consequence, the usefulness of this PR is only to work on podman, where the container readiness is not implemented. Since it creates a dependency on a log entry, I think it is not worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emitting a log statement after Collector has completed its startup procedure (including connecting to Sensor)
will prevent loosing some signals during tests.
Checklist