Split slim builds in local gha runner and remote vm #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separation should make it a little easier to follow the workflows, since each of them will only have the steps needed for the type of build taking place. Additional motivation for this is in having better handling of external PRs, since a PR from a fork will not have the required credentials to create a remote VM in our GCP projects.
Molter73
force-pushed
the
mauro/ci-split-slim-builds
branch
from
996972f
to
6614434
Compare
Stringy
approved these changes
Mar 14, 2024
Co-authored-by: Giles Hutton <[email protected]>
Molter73
force-pushed
the
mauro/ci-split-slim-builds
branch
from
9f5cf50
to
437d365
Compare
JoukoVirtanen
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This separation should make it a little easier to follow the workflows, since each of them will only have the steps needed for the type of build taking place. Additional motivation for this is in having better handling of external PRs, since a PR from a fork will not have the required credentials to create a remote VM in our GCP projects.
For the time being, this is very much some personal investigating and team feedback is very much needed.
Checklist
Testing Performed
run-multiarch-buildslabelrun-multiarch-buildslabel.