-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s metadata from falco #1606
Merged
Merged
K8s metadata from falco #1606
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b623e54
Extract k8s metadata from Falco's container engines
Molter73 d7fb9bc
Add changes missing after splitting the branch
Molter73 233b287
Ensure lock is kept
Molter73 ea234c9
Use find instead of count/at
Molter73 7f838e7
Add an introspection endpoint for container metadata (#1614)
Molter73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
#ifndef _K8S_H_ | ||
#define _K8S_H_ | ||
|
||
#include <sstream> | ||
#include <string_view> | ||
|
||
#include "system-inspector/EventExtractor.h" | ||
|
||
namespace collector { | ||
|
||
class K8s { | ||
public: | ||
K8s(sinsp* inspector) : inspector_(inspector) { | ||
event_extractor_.Init(inspector); | ||
} | ||
|
||
inline std::string_view GetNamespace(sinsp_evt* event) { | ||
const char* ns = event_extractor_.get_k8s_namespace(event); | ||
return ns != nullptr ? ns : ""; | ||
} | ||
|
||
inline std::string_view GetNamespace(const std::string& container_id) { | ||
return GetContainerLabel(container_id, "io.kubernetes.pod.namespace"); | ||
} | ||
|
||
std::string GetContainerLabels(const std::string& container_id) { | ||
const auto container = inspector_->m_container_manager.get_container(container_id); | ||
if (container == nullptr) { | ||
return ""; | ||
} | ||
|
||
std::stringstream ss; | ||
|
||
for (const auto& [key, value] : container->m_labels) { | ||
ss << key << ":" << value << ","; | ||
} | ||
|
||
return ss.str(); | ||
} | ||
|
||
inline std::string_view GetContainerLabel(const std::string& container_id, const std::string& label) { | ||
const auto container = inspector_->m_container_manager.get_container(container_id); | ||
if (container == nullptr || container->m_labels.count(label) == 0) { | ||
return ""; | ||
} | ||
return container->m_labels.at(label); | ||
} | ||
|
||
private: | ||
system_inspector::EventExtractor event_extractor_; | ||
sinsp* inspector_; | ||
}; | ||
|
||
} // namespace collector | ||
|
||
#endif // _K8S_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
count
seems inefficient.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's what Falco does so I didn't pay it too much care,
count
returns either 1 or 0 sincemap
doesn't allow duplicate keys (see https://en.cppreference.com/w/cpp/container/map/count)I could change it to
find
, but I think the slowest operation will be creating the copy of the string either way(And as I write this comment I realize there are some changes missing here that are in #1614, I'll add them back and rebase the other 2 PRs)