-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falco update 2024-03-22 #1608
Merged
Merged
Falco update 2024-03-22 #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringy
force-pushed
the
giles/falco-update-2024-03-21
branch
from
March 22, 2024 17:43
bbe505d
to
d083d1a
Compare
Stringy
force-pushed
the
giles/falco-update-2024-03-21
branch
3 times, most recently
from
March 28, 2024 09:55
febdbf4
to
f259357
Compare
Stringy
force-pushed
the
giles/falco-update-2024-03-21
branch
2 times, most recently
from
April 3, 2024 09:26
23048f4
to
256704e
Compare
cos is failing because of the on-going kernel-packer problems. It should pass, like all the other platforms, once we have kernel sources. |
erthalion
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Couple of questions below.
erthalion
approved these changes
Apr 9, 2024
Not sure about the arm failures:
Implies that we're trying to run non-arm64 images |
Stringy
force-pushed
the
giles/falco-update-2024-03-21
branch
2 times, most recently
from
April 15, 2024 16:36
29eb0a0
to
021e115
Compare
…r development easier
Stringy
force-pushed
the
giles/falco-update-2024-03-21
branch
from
April 16, 2024 08:24
021e115
to
c072c3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes required to update falco submodule to upstream 0.15.0
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.