Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falco update 2024-03-22 #1608

Merged
merged 27 commits into from
Apr 16, 2024
Merged

Falco update 2024-03-22 #1608

merged 27 commits into from
Apr 16, 2024

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Mar 22, 2024

Description

Changes required to update falco submodule to upstream 0.15.0

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@Stringy Stringy force-pushed the giles/falco-update-2024-03-21 branch from bbe505d to d083d1a Compare March 22, 2024 17:43
@Stringy Stringy added the run-multiarch-builds Run steps for non-x86 archs. label Mar 26, 2024
@Stringy Stringy force-pushed the giles/falco-update-2024-03-21 branch 3 times, most recently from febdbf4 to f259357 Compare March 28, 2024 09:55
@Stringy Stringy force-pushed the giles/falco-update-2024-03-21 branch 2 times, most recently from 23048f4 to 256704e Compare April 3, 2024 09:26
@Stringy Stringy removed the run-multiarch-builds Run steps for non-x86 archs. label Apr 4, 2024
@Stringy Stringy marked this pull request as ready for review April 4, 2024 10:22
@Stringy Stringy requested a review from a team as a code owner April 4, 2024 10:22
@Stringy
Copy link
Collaborator Author

Stringy commented Apr 4, 2024

cos is failing because of the on-going kernel-packer problems. It should pass, like all the other platforms, once we have kernel sources.

Copy link
Contributor

@erthalion erthalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Couple of questions below.

kernel-modules/probe/Makefile Show resolved Hide resolved
kernel-modules/build/utils.sh Show resolved Hide resolved
kernel-modules/build/kernel-splitter.py Show resolved Hide resolved
docs/falco-update.md Outdated Show resolved Hide resolved
docs/falco-update.md Show resolved Hide resolved
collector/test/ProcessSignalFormatterTest.cpp Show resolved Hide resolved
@Stringy Stringy requested a review from erthalion April 8, 2024 08:01
@Stringy Stringy added the run-multiarch-builds Run steps for non-x86 archs. label Apr 9, 2024
@Stringy
Copy link
Collaborator Author

Stringy commented Apr 9, 2024

Not sure about the arm failures:

Collector Version: 3.18.x-143-gd8d9f8ceaf
OS: Red Hat Enterprise Linux 9.3 (Plow)
Kernel Version: 5.14.0-362.18.1.el9_3.aarch64
Starting StackRox Collector...
/usr/local/bin/collector-wrapper.sh: line 5: /usr/local/bin/collector: cannot execute binary file: Exec format error
/usr/local/bin/collector-wrapper.sh: line 5: /usr/local/bin/collector: Success

Implies that we're trying to run non-arm64 images

@Stringy Stringy force-pushed the giles/falco-update-2024-03-21 branch 2 times, most recently from 29eb0a0 to 021e115 Compare April 15, 2024 16:36
@Stringy Stringy force-pushed the giles/falco-update-2024-03-21 branch from 021e115 to c072c3b Compare April 16, 2024 08:24
@Stringy Stringy merged commit ddcf390 into master Apr 16, 2024
94 of 101 checks passed
@Stringy Stringy deleted the giles/falco-update-2024-03-21 branch April 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants