Add an introspection endpoint for container metadata #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2024
Molter73
force-pushed
the
mauro/k8s-metadata-introspection-endpoint
branch
from
df4679f
to
af350d6
Compare
ovalenti
approved these changes
Apr 2, 2024
Comment on lines
+14
to
+15
| static QueryParams ParseParameters(const char* queryString); | ||
| static std::optional<std::string> GetParameter(const QueryParams& params, const std::string& paramName); |
There was a problem hiding this comment.
These methods are not used in the PR. However, I think they will be soon, as we add more endpoints.
Molter73
force-pushed
the
mauro/k8s-metadata-introspection-endpoint
branch
from
af350d6
to
6476c65
Compare
ovalenti
reviewed
Apr 5, 2024
ovalenti
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an introspection endpoint to collector which can be used to retrieve container metadata by providing it with a container ID. At the time, the only data that is returned by the endpoint is the same container ID that was provided and the k8s namespace the container belongs to. This endpoint will enable testing of the #1606 PR without need for changes to our communication with sensor.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Manually tested the new endpoint.