POC for using stackrox/storage/ResourceCollection #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as filter object for runtime config
robbycochran
force-pushed
the
rc-resource-selector-poc
branch
from
1b2f70a
to
faa22e7
Compare
3 tasks
|
Looks like a good start. Thanks for doing this. Instead of doing a traditional PR review I have decided to build on your PR. My PR is here #1622 Improvements include use of the AND operator, checking cluster level rules, refactoring to reduce nesting, and more unit tests. |
I also added the ability to check if there is a match in the embedded collections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example for using a ResourceCollection storage object as namespace filter for runtime config.
Updated stackrox proto to 4.4 to get latest version of the ResourceCollection proto, which also required including transitive dependencies.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.