eBPF turn-off-ening #1667
Merged
eBPF turn-off-ening #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
reviewed
May 10, 2024
Stringy
force-pushed
the
giles/ebpf-turnoffening
branch
from
26ff782
to
348279a
Compare
Stringy
force-pushed
the
giles/ebpf-turnoffening
branch
2 times, most recently
from
e103ce3
to
52e9184
Compare
Molter73
reviewed
May 13, 2024
erthalion
reviewed
May 15, 2024
Stringy
force-pushed
the
giles/ebpf-turnoffening
branch
from
3112cdd
to
951b4ef
Compare
Stringy
removed
run-cpaas-steps
Stringy
added
all-integration-tests
run-cpaas-steps
Stringy
force-pushed
the
giles/ebpf-turnoffening
branch
from
26e004d
to
11a4ae8
Compare
erthalion
approved these changes
May 28, 2024
| if (host.IsRHEL86()) { | ||
| CLOG(INFO) << "RHEL 8.6 on ppc64le does not support CORE_BPF, switching to eBPF collection method."; | ||
| hconfig->SetCollectionMethod(CollectionMethod::EBPF); | ||
| if (k.kernel == 4 && k.major == 18 && k.build_id < 477) { |
There was a problem hiding this comment.
It wont hurt to reference something here to explain why is that.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make slim and full collector images the same.
Keep legacy driver builds on master, but separate them from the main CI workflow
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.