ROX-20232: Remove all but single collector pipeline #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that the image is pushed to both expected locations.
msugakov
force-pushed
the
misha/ROX-20232-groom-collector-konflux-further
branch
from
240dd82
to
f630740
Compare
msugakov
changed the title
| value: $(tasks.build-container.results.IMAGE_URL) | ||
| - name: ADDITIONAL_TAGS | ||
| value: | ||
| - $(tasks.determine-image-tag.results.image-tag)-latest |
There was a problem hiding this comment.
When (if at all) will the -latest and -slim tags be removed? Can we link a Jira issue here?
There was a problem hiding this comment.
So far, it's a distant plan for which I created the epic ROX-24402.
There was a problem hiding this comment.
Thanks for updating the comment.
tommartensen
approved these changes
May 27, 2024
It won't build anymore, but will cause trouble in the enterprise contract runs (outdated task definitions), because it is part of every snapshot. I suggest to remove it now. |
Ok, will remove after I merge this and after I back up components. |
Molter73
reviewed
May 29, 2024
Molter73
approved these changes
May 29, 2024
msugakov
added a commit
to stackrox/rhtap-data
that referenced
this pull request
May 31, 2024
Before deleting collector-slim. See stackrox/collector#1687 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up on #1676 applying the approach from stackrox/scanner#1526.
Also follows up on #1684 cleaning slim stage in Dockerfile and removing slim pipelines.
I use apply-tags task to ensure both
-latestand-slimsuffixes are provided. I use it to resolve ROX-24116 too.The only thing I worry here is that we'll have a dangling
collector-slimKonflux component and I wonder if it will cause any trouble. At some point, we'll just kill it.I suggest to review this PR by commits because I tried splitting changes and provided brief messages.
Checklist
These aren't relevant and won't be done:
Testing Performed
All these exist and point to the same image:
quay.io/rhacs-eng/collector:3.18.x-264-ga99ac1e8c3-fastquay.io/rhacs-eng/collector:3.18.x-264-ga99ac1e8c3-fast-slimquay.io/rhacs-eng/collector:3.18.x-264-ga99ac1e8c3-fast-latestquay.io/rhacs-eng/collector:konflux-a99ac1e8c3cc2e19d2714aac0ee4dd5523be2dc4