ROX-26528: add rpms-signature-scan task to pipeline #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msugakov
approved these changes
Oct 14, 2024
Comment on lines
568
to
572
| params: | ||
| - name: image-digest | ||
| value: $(tasks.build-image-index.results.IMAGE_DIGEST) | ||
| - name: image-url | ||
| value: $(tasks.build-image-index.results.IMAGE_URL) |
There was a problem hiding this comment.
[nit] The indentation looks too off here compared to other tasks.
There were no warnings or errors reported by the scan when I looked at the results. |
|
This is the output for the task (from the second commit in this PR). The task iterates through all architectures found in the index image to check for the presence of unsigned RPMs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new required task to pipeline.
Checklist
[ ] Updated documentation accordinglyAutomated testing
[ ] Added unit tests[ ] Added integration tests[ ] Added regression testsIf any of these don't apply, please comment below.
Testing Performed
No new tests required. Konflux CI pipeline passes.