-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-26026: Make determine-image-tag
recognize git tags
#1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msugakov
added
the
backport-for-4.6-konflux-release
https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439
label
Oct 30, 2024
|
msugakov
changed the title
ROX-26026: Add handling for git tags in Konflux
ROX-26026: Make Oct 30, 2024
determine-image-tag
recognize git tags
Molter73
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
msugakov
added a commit
that referenced
this pull request
Nov 1, 2024
1 task
tommartensen
approved these changes
Nov 4, 2024
msugakov
added a commit
that referenced
this pull request
Nov 4, 2024
msugakov
removed
the
backport-for-4.6-konflux-release
https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439
label
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-fast
suffixes to unblock the work on ROX-24468: Retag ScannerV2 and Collector containers (take 3) stackrox#13079.Checklist
[ ] Updated documentation accordinglyAfter merge:
3.misha.*
tags.Automated testing
No change to automated tests.
Testing Performed
Checked that:
<git-tag>-fast
.version
label in the image is the same<git-tag>-fast
.