Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-26026: Make determine-image-tag recognize git tags #1920

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Oct 30, 2024

Description

Checklist

  • Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

After merge:

  • Delete 3.misha.* tags.

Automated testing

No change to automated tests.

Testing Performed

Checked that:

  • CI produces image tagged as <git-tag>-fast.
  • version label in the image is the same <git-tag>-fast.
  • Konflux CI is happy.
  • GHA tests for Konflux-built images are happy in PR.
  • Tag pushes get GHA tests triggered (Add tags to konflux tests #1914) and these succeed.

@msugakov msugakov added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Oct 30, 2024
@msugakov
Copy link
Contributor Author

amd64-integration-tests (sles) failed but others passed. It seems to be a VM provisioning issue https://github.com/stackrox/collector/actions/runs/11594784253/job/32283367294?pr=1920#step:8:106
I take it as we're doing fine.

@msugakov
Copy link
Contributor Author

Expected failure for multiple tags:
image

@msugakov msugakov changed the title ROX-26026: Add handling for git tags in Konflux ROX-26026: Make determine-image-tag recognize git tags Oct 30, 2024
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msugakov msugakov merged commit 735493b into master Nov 4, 2024
67 of 69 checks passed
@msugakov msugakov deleted the misha/ROX-26026-handle-git-tags-in-konflux branch November 4, 2024 11:31
msugakov added a commit that referenced this pull request Nov 4, 2024
@msugakov msugakov removed the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants