Enable building with vcpkg #1942
Open
+126
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables building collector outside of the builder container by leveraging the [vcpkg](https://vcpkg.io) package manager. This is not ideal for CI, since vcpkg pulls from the internet so isolated builds are not possible, but it is more convenient than having to install all libraries to the system. A simple CMakePresets.json file was added to enable even easier use. Command for using this build is: cmake --preset=vcpkg
Molter73
force-pushed
the
mauro/vcpkg-build
branch
2 times, most recently
from
87f810d
to
48e4c0f
Compare
Molter73
commented
Nov 7, 2024
| @@ -68,16 +63,12 @@ add_definitions(-DSCAP_SOCKET_ONLY_FD) | |||
| # Filter out some cgroup subsys | |||
| add_definitions("-DINTERESTING_SUBSYS=\"perf_event\", \"cpu\", \"cpuset\", \"memory\"") | |||
|
|
|||
| add_definitions(-DASSERT_TO_LOG) | |||
There was a problem hiding this comment.
This line is duplicated in line 63
Molter73
force-pushed
the
mauro/vcpkg-build
branch
from
48e4c0f
to
39c4745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables building collector outside of the builder container by leveraging the vcpkg package manager. This is not ideal for CI, since vcpkg pulls from the internet so isolated builds are not possible, but it is more convenient than having to install all libraries to the system.
A simple CMakePresets.json file was added to enable even easier use. Command for using this build is:
cmake --preset=vcpkgChecklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Manually checked building collector with vcpkg.
CI should check the regular build for collector is not broken.