Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix upload artifact action, bump go version #124

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

Maddosaurus
Copy link
Member

@Maddosaurus Maddosaurus commented Sep 4, 2024

upload-artifacts introduced a breaking change with 4.4.0 in which it skips hidden folders by default.
As the binaries are compiled to .gobin, this led to failing runs.
This PR fixes this by explicitly configuring the action to include hidden dirs.

I also took the opportunity to bump Go to a more recent version.

@Maddosaurus Maddosaurus changed the title chore:Bump go version chore: Fix upload artifact action, bump go version Sep 4, 2024
@Maddosaurus Maddosaurus requested a review from a team September 4, 2024 12:22
@Maddosaurus Maddosaurus added the pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted label Sep 4, 2024
@Maddosaurus Maddosaurus merged commit 5ca4014 into main Sep 5, 2024
5 checks passed
@Maddosaurus Maddosaurus deleted the mm/bump-go branch September 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pls-merge Indicates to the *reviewer* that the PR can be merged once tests pass and approval is granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants