feat(retry): Add retry logic #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvalerom
force-pushed
the
lvm/add-retry-logic
branch
from
2356704 to
8631347
Compare
vikin91
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
LGTM! By looking at https://github.com/stackrox/external-network-pusher/actions/runs/12264605728?pr=146 I see that it was tested and works.
I started commenting on potential further improvements, but I saw there are much more improvements possible than those two, so feel free to skip those.
Yeah there are a few inconsistencies, especially in the log messages. Maybe we can open a follow-up PR at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a call to any of the providers' APIs fails we do not retry and the entire run fails. This PR adds a retry logic to retry for a few minutes before failing the entire run.