Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compilation code, deprecate constructing a model without ever compiling #700

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

WardBrian
Copy link
Member

The pre-2.0 part of #695

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

This moves the compilation code outside the model class and issues deprecation warnings for cases we'd like to disallow in 2.0, namely the use of a CmdStanModel without an executable at all.

I think if we get this in, I can update #691, and then we can release 1.2.0

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation.

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #700 (19ac74e) into develop (13fe59f) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #700      +/-   ##
===========================================
+ Coverage    79.78%   79.86%   +0.08%     
===========================================
  Files           75       75              
  Lines        11316    11367      +51     
===========================================
+ Hits          9028     9078      +50     
- Misses        2288     2289       +1     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cleaner!

@WardBrian WardBrian merged commit 2cf6120 into develop Sep 21, 2023
13 checks passed
@WardBrian WardBrian deleted the feature/update-constructor-deprecations branch September 21, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants