Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsetting psis objects #110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Subsetting psis objects #110

wants to merge 4 commits into from

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jun 3, 2019

The PR introduces a subset() method for "psis" objects. This is useful if you want to drop some of the contents of a "psis" object without breaking it. For example, bayesplot has an option for this for ppc_loo_intervals() (https://mc-stan.org/bayesplot/reference/PPC-loo.html?q=subset#arguments) implemented via an internal function but it would be good if loo provided this functionality and bayesplot can call it.

@jgabry jgabry added the feature label Jun 3, 2019
@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #110 into master will decrease coverage by 2.76%.
The diff coverage is 91.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   97.73%   94.97%   -2.77%     
==========================================
  Files          16       19       +3     
  Lines        1281     2048     +767     
==========================================
+ Hits         1252     1945     +693     
- Misses         29      103      +74
Impacted Files Coverage Δ
R/loo_compare.R 94.79% <100%> (+0.6%) ⬆️
R/waic.R 100% <100%> (ø) ⬆️
R/psis_approximate_posterior.R 71.42% <59.37%> (-24.58%) ⬇️
R/loo.R 91.87% <70.73%> (-5.63%) ⬇️
R/loo_compare.psis_loo_ss_list.R 84.82% <84.82%> (ø)
R/loo_approximate_posterior.R 92.1% <92.1%> (ø)
R/print.R 96.96% <94.44%> (-1.15%) ⬇️
R/loo_subsample.R 95.4% <95.4%> (ø)
R/effective_sample_sizes.R 97.27% <0%> (-0.23%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a9312...e9c900b. Read the comment docs.

@avehtari
Copy link
Collaborator

@jgabry is this still work in progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants