Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial contact center base scenario setup and added summarization scenario #2569

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chuanw24
Copy link

No description provided.

Comment on lines +49 to +51
sampling_min_length: Optional[int] = None,
sampling_max_length: Optional[int] = None,
doc_max_length: Optional[int] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: names like
doc_filter_min_length, doc_filter_max_length, doc_truncation_max_length
or
filter_doc_min_length, filter_doc_max_length, truncate_doc_max_length
or
doc_filter_min_words, doc_filter_max_words, doc_truncation_max_words
would be more self-evident.

sampling_min_length will be filtered out.
Useful for preventing the adapter from sampling
really small documents.
sampling_max_length: Int indicating maximum length for training
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change comments to indicate that "length" is the number of words, not characters (or change the variable names to reflect this)

self.dataset_path = dataset_path
self.sampling_min_length = sampling_min_length
self.sampling_max_length = sampling_max_length
self.doc_max_length = doc_max_length
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used. Are you missing the truncation logic? Alternatively, just delete this parameter.

Scenario for contact center conversational summarization.
"""

name = "cc_convo_summarization"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick a consistent name that is used both here and as the filename. I'd prefer both to be contact_center_conversation_summarization, but I'd also be fine with both being cc_convo_summarization.

Likewise with the other file.

Comment on lines +33 to +35
name = "cc_conversation"
description = "Base scenario for contact center conversation tasks"
tags = ["cc_conversation"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just delete name, description and tags since this is not a concrete class and can't be instantated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants