Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix R/B channel switch in skin tone calculation #2589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbitr
Copy link

@rbitr rbitr commented Apr 24, 2024

Blue and Red channels were switched, img_rgba is in rgb order but blue is being pulled from channel 0, red from channel 2. This PR swaps them to the correct channels.

@yifanmai yifanmai requested a review from teetone April 24, 2024 15:54
@yifanmai
Copy link
Collaborator

Thanks @rbitr for catching this!

@teetone could you take a look?

@yifanmai
Copy link
Collaborator

yifanmai commented May 8, 2024

Ping @teetone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants