Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor config streamlining #35

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Minor config streamlining #35

merged 4 commits into from
Jun 9, 2024

Conversation

thearossman
Copy link
Collaborator

  • Troubleshooting bindgen + clang/llvm note
  • Use LD_LIBRARY_PATH environment variable in build script to remove need to modify build script for ARM devices
  • Throw descriptive error message if port ID is invalid

@thearossman thearossman requested a review from thegwan June 9, 2024 17:25
thegwan
thegwan approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@thegwan thegwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thearossman thearossman merged commit 5ea5dae into stanford-esrg:main Jun 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegwan thegwan thegwan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thearossman @thegwan