Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Minor] Documentation Fix for Enabling the parameter
output_original_output
Description
The
IntervenableModel
class requires theoutput_original_output
boolean flag to be enabled for the code to function as expected. Not passing this parameter in the Jupyter notebook while intervening on ResNet models results in an empty dictionary for original outputs. Consequently, attempting to compute the difference between the intervened output and the original output raises the following error:AttributeError: 'NoneType' object has no attribute 'logits'
Testing Done
The code was tested by including the parameter
output_original_output=True
. This change allowed for the correct computation of outputs without errors and the html build was verified accordingly.This could however be changed to making the default value set to
True
when defining these functions in theintervenable_base
module but these might be broader design choices. The same changes could possible result in erroring out in other blocks for different model architecture if the difference is computed but I haven't tested that.Checklist:
[Your Priority] Your Title