Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Icon to open blank #2789

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Adding Icon to open blank #2789

wants to merge 9 commits into from

Conversation

TalBenAvi
Copy link
Collaborator

No description provided.

@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 1, 2024 09:02 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 1, 2024 09:02 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 1, 2024 09:02 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 6, 2024 12:00 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 6, 2024 12:00 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 6, 2024 12:00 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 6, 2024 12:02 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 6, 2024 12:02 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 6, 2024 12:02 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi requested a review from igalst May 6, 2024 12:02
igalst
igalst requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@igalst igalst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to also change the size of the text and add GTM event.
@TalBenAvi Why is it part of the PR?

workspaces/website/src/blocks/HomepageHero.tsx Show resolved Hide resolved
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 7, 2024 07:31 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 7, 2024 07:31 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 7, 2024 07:31 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 7, 2024 07:59 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 7, 2024 07:59 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 7, 2024 07:59 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi requested a review from igalst May 8, 2024 10:46
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 9, 2024 09:09 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 9, 2024 09:09 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 9, 2024 09:09 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook Add-an-open-blank-icon May 9, 2024 12:28 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website Add-an-open-blank-icon May 9, 2024 12:28 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS Add-an-open-blank-icon May 9, 2024 12:28 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalst igalst igalst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalBenAvi @igalst