Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move isomorphic-fetch to dev dependency #979

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

penovicp
Copy link
Collaborator

Motivation and Resolution

Removes isomorphic-fetch as a production dependency because a fetch fallback should no longer be necessary in the majority of environments.

Usage related changes

Most users should not be affected. If there are some edge cases that still need a fetch fallback, a baseFetch override is enabled for the RpcProvider and RpcChannel classes through which it can be set.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvkelawala @janek26 @yoga-braavos Can you check this one, will this still work for you ?

Copy link
Collaborator

@avimak avimak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm good with the main change, but pls note the degradation related to specVersion; generally speaking, we should have it assigned locally next to this.chainId in any constructor

src/channel/rpc_0_6.ts Outdated Show resolved Hide resolved
@penovicp penovicp changed the base branch from develop to next-version April 12, 2024 04:07
@tabaktoni tabaktoni added the pending need update label May 3, 2024
@penovicp penovicp deleted the branch develop June 21, 2024 04:26
@penovicp penovicp closed this Jun 21, 2024
@penovicp penovicp reopened this Jun 21, 2024
@penovicp penovicp changed the base branch from next-version to develop June 21, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending need update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants