Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cairo Programs #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: Add Cairo Programs #1

wants to merge 14 commits into from

Conversation

zmalatrax
Copy link
Collaborator

@zmalatrax zmalatrax commented Jun 20, 2024

Add a baseline for the Cairo VM conformance tests. The Cairo programs come from the cairo-vm/cairo_programs folder.

I'm proposing a reordering of the directory tree.

  • cairo_programs renamed conformance
  • Clear distinction between Cairo and Cairo Zero programs (cairo and cairo-0 dir)
  • A sub-directory starknet for Starknet contracts in the cairo dir
  • Removal of the benchmarks programs (or at least refactored outside conformance
  • Enforce use of snake_case for every directory (in case of local import in Cairo programs)
  • Update the CI to verify that every Cairo programs compile (Cairo Zero compiler, Cairo 1 compiler & Cairo 2 compiler for Programs/Contracts) (currently only the Cairo Zero programs compilation has been set up in the CI)

A few things that haven't been done yet/need further thinking:

  • Separate in two distinct folders the programs with and without hints
  • The proof-programs only links Cairo Zero programs, either make it as subdir of cairo-0 or add Cairo programs as well 🤔
  • Should the noretrocompat be kept? I think so
  • Should the yet to be released tests included? (e.g. mod_builtin_feature, print_feature)

Directly include the compiled version of the programs ?

@zmalatrax zmalatrax self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant