Impl num traits #18
Merged
Impl num traits #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested review from
spapinistarkware,
AbdelStark,
dan-starkware and
xJonathanLEI
as code owners
0xLucqs
reviewed
Nov 29, 2023
Oppen
approved these changes
Nov 29, 2023
|
rebase |
tdelabro
force-pushed
the
impl-num-traits
branch
from
b6cab88
to
68543e9
Compare
|
@Oppen I also added a commit to fix the way the alloc feature was used. It was a bit weird, potentially a bug |
0xLucqs
requested changes
Dec 21, 2023
tdelabro
force-pushed
the
impl-num-traits
branch
from
43a5e08
to
15e9fff
Compare
0xLucqs
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7
What is the new behavior?
num_traits::{Inv, Pow, One, Zero}are implemented onFeltThey exist behind a feature flag. So if you don't need them, you can build the crate without.
Does this introduce a breaking change?
No
Other information