Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rb configs #1657

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

mmenanno
Copy link
Contributor

@mmenanno mmenanno commented Feb 19, 2024

Starting to update this, looks like nothing merged is relying on this common folder yet, so this only affects my future projects.

@Maista6969
Copy link
Collaborator

While we're waiting for stashapp/stash#4433 you should be aware that any scrapers that get updated/reinstalled by Stash will overwrite any files that the user has modified, which might include configuration 😅

This is usually just an annoyance: most script scrapers don't see that many updates... but for "packages" like py_common and rb_common it can be more of a headache since users don't expect an unrelated scraper install to affect their "main config" that they've set in these libraries 🙂

The workaround I've implemented in py_common/config.py is a helper function called get_config that will persist a config.ini file in the same directory as whatever file calls it, which in turn is used both internally in py_common/graphql.py and externally in scrapers like GEVI.py

It's not elegant, but hopefully we'll get proper scraper configuration in Stash itself before too long

@mmenanno
Copy link
Contributor Author

Ah thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants