Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin - themeSwitch] rm hardcoded css #259

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[plugin - themeSwitch] rm hardcoded css #259

merged 2 commits into from
Feb 22, 2024

Conversation

Tetrax-10
Copy link
Collaborator

Currently, the CommunityScripts repository has become bloated due to duplication of themes caused by this plugin. This PR addresses this issue by installing the theme instead of appending hardcoded CSS to the DOM. This way, there is no need to check for updates and copy them to this plugin.

@Tetrax-10 Tetrax-10 self-assigned this Feb 21, 2024
@Tetrax-10 Tetrax-10 changed the title Install themes instead of hardcoded css [plugin - themeSwitch] Install themes instead of hardcoded css Feb 21, 2024
@Tetrax-10 Tetrax-10 changed the title [plugin - themeSwitch] Install themes instead of hardcoded css [plugin - themeSwitch] rm hardcoded css Feb 22, 2024
@Tetrax-10
Copy link
Collaborator Author

@elkorol d3968b4 : Now css are imported dynamically to reduce plugin size and its much more efficient.

@Tetrax-10 Tetrax-10 merged commit 5f4e7d0 into stashapp:main Feb 22, 2024
2 checks passed
@Tetrax-10 Tetrax-10 deleted the theme-switch branch February 22, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant