[Hot Cards] Fix element duplication and missing homepage holo effect #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- waitForImageLoad was not working as expected. Now receives an element instead of a selector.
There was a bug associated with this that happened when, for example, if we were in home and a user navigated to a gallery that had no performer or scene linked, when navigating backwards while waitForClass had not yet timed out, there would be a second waitForClass that would run, thus duplicating the hot-card elements.
When the user navigated to home, if he navigated to another section before the timeout ended, (handleHotCards * enabled cards) functions were run, and, if there were hot cards in the given section, the elements were duplicated because of the additional handleHotCards that would run in the current page. - Add reusable overrideHistoryMethods function in helpers.js - Replace code with new overrideHistoryMethods function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplication of elements was not noticeable until the holo style was introduced, which in case of duplication, becomes evident in the DOM.