[Hot Cards] Rename Movie to Group and enhance homepage loading #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refreshing is no longer needed if the user updates his plugin configuration. - Reorganize code - Move configuration/settings related code to configuartionHandler.js - Move registerPathChangeListener function to helpers.js - Add function to update configuration if user comes from /settings page
Logic replaced by a mutation observer to check if all recommendation rows for the same card type have their slider initialized.
Previous solution was not consistent.
To prevent duplication of elements when the user clicks/reloads a section multiple times we add 'activeHotCardTypes' to track for each card type on the homepage, and for every other section only one card type will be active. - 'backupImgElements' and 'holoElements' arrays were added to restore the img nodes and avoid duplication of the holo effect on cards. - Renamed variables for consistency and improve meaning.
Updates the definition in all files and adds the subgroups path to the group pattern.
HandyRandyx
changed the title
|
LGTM, only nitpicks being that some stuff can be a class/css var |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable:
movietogroup. Adds newsubgroupspath.Other:
I've been testing it and everything seems to be working fine, but let me know if you find anything odd.