Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw errors from actor snapshots to trigger error boundaries in React #4663

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Throw errors from actor snapshots to trigger error boundaries in React #4663

wants to merge 3 commits into from
+51 −17

Conversation

Andarist
Copy link
Member

No description provided.

@Andarist Andarist requested a review from davidkpiano January 10, 2024 16:41
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b946414

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 10, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af0316f:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

@Andarist Andarist force-pushed the throw-errors-in-react branch from 6d515d0 to af0316f Compare January 10, 2024 16:50
davidkpiano
davidkpiano approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@davidkpiano davidkpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkpiano davidkpiano davidkpiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @davidkpiano