-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add basic support for state invariant
#4944
Open
davidkpiano
wants to merge
7
commits into
main
Choose a base branch
from
davidkpiano/state-invariants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
50a0b23
Add basic support for invariants
davidkpiano e062b68
Add tests
davidkpiano 3c1edb4
Types
davidkpiano 879ae52
Rename test
davidkpiano a2a274f
Merge branch 'main' into davidkpiano/state-invariants
davidkpiano 9c69ad1
Merge branch 'main' into davidkpiano/state-invariants
davidkpiano b64e763
Merge branch 'main' into davidkpiano/state-invariants
davidkpiano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,221 @@ | ||
import { assign, createActor, createMachine } from '../src'; | ||
|
||
describe('state invariants', () => { | ||
it('throws an error and does not transition if the invariant throws', () => { | ||
const machine = createMachine({ | ||
initial: 'idle', | ||
states: { | ||
idle: { | ||
on: { | ||
loadUser: { | ||
target: 'userLoaded' | ||
} | ||
} | ||
}, | ||
userLoaded: { | ||
invariant: (x) => { | ||
if (!x.context.user) { | ||
throw new Error('User not loaded'); | ||
} | ||
} | ||
} | ||
} | ||
}); | ||
const spy = jest.fn(); | ||
|
||
const actor = createActor(machine); | ||
actor.subscribe({ | ||
error: spy | ||
}); | ||
actor.start(); | ||
|
||
actor.send({ type: 'loadUser' }); | ||
|
||
expect(spy).toHaveBeenCalledWith(new Error('User not loaded')); | ||
|
||
expect(actor.getSnapshot().value).toEqual('idle'); | ||
}); | ||
|
||
it('transitions as normal if the invariant does not fail', () => { | ||
const machine = createMachine({ | ||
initial: 'idle', | ||
states: { | ||
idle: { | ||
on: { | ||
loadUser: { | ||
target: 'userLoaded', | ||
actions: assign({ user: () => ({ name: 'David' }) }) | ||
} | ||
} | ||
}, | ||
userLoaded: { | ||
invariant: (x) => { | ||
if (!x.context.user) { | ||
throw new Error('User not loaded'); | ||
} | ||
} | ||
} | ||
} | ||
}); | ||
const spy = jest.fn(); | ||
|
||
const actor = createActor(machine); | ||
actor.subscribe({ | ||
error: spy | ||
}); | ||
actor.start(); | ||
|
||
actor.send({ type: 'loadUser' }); | ||
|
||
expect(spy).not.toHaveBeenCalled(); | ||
|
||
expect(actor.getSnapshot().value).toEqual('userLoaded'); | ||
}); | ||
|
||
it('throws an error and does not transition if the invariant fails on a transition within the state', () => { | ||
const machine = createMachine({ | ||
initial: 'userLoaded', | ||
states: { | ||
userLoaded: { | ||
initial: 'active', | ||
states: { | ||
active: { | ||
on: { | ||
deactivate: 'inactive' | ||
} | ||
}, | ||
inactive: { | ||
entry: assign({ user: null }) | ||
} | ||
}, | ||
invariant: (x) => { | ||
if (!x.context.user) { | ||
throw new Error('User not loaded'); | ||
} | ||
}, | ||
entry: assign({ user: { name: 'David' } }) | ||
} | ||
} | ||
}); | ||
const spy = jest.fn(); | ||
|
||
const actor = createActor(machine); | ||
actor.subscribe({ | ||
error: spy | ||
}); | ||
actor.start(); | ||
|
||
actor.send({ type: 'deactivate' }); | ||
|
||
expect(spy).toHaveBeenCalledWith(new Error('User not loaded')); | ||
expect(actor.getSnapshot().value).toEqual({ userLoaded: 'active' }); | ||
}); | ||
|
||
it('does not throw an error when exiting a state with an invariant if the exit action clears the context', () => { | ||
const machine = createMachine({ | ||
initial: 'userLoaded', | ||
states: { | ||
userLoaded: { | ||
invariant: (x) => { | ||
if (!x.context.user) { | ||
throw new Error('User not loaded'); | ||
} | ||
}, | ||
entry: assign({ user: { name: 'David' } }), | ||
exit: assign({ user: null }), | ||
on: { | ||
logout: 'idle' | ||
} | ||
}, | ||
idle: {} | ||
} | ||
}); | ||
const spy = jest.fn(); | ||
|
||
const actor = createActor(machine); | ||
actor.subscribe({ | ||
error: spy | ||
}); | ||
actor.start(); | ||
|
||
actor.send({ type: 'logout' }); | ||
|
||
expect(spy).not.toHaveBeenCalled(); | ||
expect(actor.getSnapshot().value).toEqual('idle'); | ||
}); | ||
|
||
it('parallel regions check for state invariants', () => { | ||
const spy = jest.fn(); | ||
|
||
const machine = createMachine({ | ||
initial: 'p', | ||
types: { | ||
context: {} as { user: { name: string; age: number } | null } | ||
}, | ||
context: { | ||
user: { | ||
name: 'David', | ||
age: 30 | ||
} | ||
}, | ||
states: { | ||
p: { | ||
type: 'parallel', | ||
states: { | ||
a: { | ||
invariant: (x) => { | ||
if (!x.context.user) { | ||
throw new Error('User not loaded'); | ||
} | ||
}, | ||
on: { | ||
updateAge: { | ||
actions: assign({ | ||
user: (x) => ({ ...x.context.user!, age: -3 }) | ||
}) | ||
} | ||
} | ||
}, | ||
b: { | ||
invariant: (x) => { | ||
if (x.context.user!.age < 0) { | ||
throw new Error('User age cannot be negative'); | ||
} | ||
}, | ||
on: { | ||
deleteUser: { | ||
actions: assign({ | ||
user: () => null | ||
}) | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
}); | ||
|
||
const actor = createActor(machine); | ||
|
||
actor.subscribe({ | ||
error: spy | ||
}); | ||
|
||
actor.start(); | ||
|
||
expect(actor.getSnapshot().value).toEqual({ | ||
p: { | ||
a: {}, | ||
b: {} | ||
} | ||
}); | ||
|
||
actor.send({ | ||
type: 'updateAge' | ||
}); | ||
|
||
expect(spy).toHaveBeenCalledWith(new Error('User age cannot be negative')); | ||
|
||
expect(actor.getSnapshot().status).toEqual('error'); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need such tests:
invariant
, the current tests only show what's the behavior when entering such statesinvariant
doesn't create a problems when we exit a state that has some invariant requirement (like, the invariant requirescontext.user
but an exit action within the exited state resets theuser
tonull
)entry
,always
andparallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added most of these