adding HTTP response code 207, Multi-Status #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Aug 14, 2024
| @@ -10,7 +10,7 @@ | |||
| {.push raises: [].} | |||
|
|
|||
| import std/[times, strutils, algorithm, sequtils] | |||
| import results | |||
| import stew/results | |||
There was a problem hiding this comment.
not sure why you closed #36, it was the better PR because it did not have this unrelated results change
There was a problem hiding this comment.
Because it stayed for too long without any reaction on it, and I assumed that something must be too wrong to be discussed... :)
|
Duplicate PR, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be easy to merge, just three lines.