Add kvstore for contract code #2165
Open
+48
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching of ContractCode from the Verkle Trie is very slow, due to chunk key caulculation requires pedersen commitment. And number of chunks is generally around 300 to 500
The only solution that seems to work would be to add the kvstore along with the
VerkleTrieRef,I am planning to use the
CoreDxKvtRef/CoreDbKvtRefSince our
VerkleTrieis already distinctVerkleTrieRef, using theCoreDxKvtRefshouldn't be a problem, we would be adding the contract code to the kv-store whenever we update contract-code, and later we can easily fetch is from the in-memory kvstore