Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix button blur icon color #598

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

prichodko
Copy link
Collaborator

@prichodko prichodko commented Oct 10, 2024

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: d965852

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 10, 2024

@prichodko is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@prichodko prichodko self-assigned this Oct 10, 2024
@prichodko prichodko requested review from a team, jkbktl, felicio and marcelines October 10, 2024 12:46
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 0:48am

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 149 to 151
'blur:text-neutral-80/40',
'dark:text-neutral-40',
'blur:dark:text-neutral-80/40',
'blur:dark:text-blur-white/70',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is dark grey blur in Figma?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

08d020a 🙈

'dark:text-neutral-40',
'blur:dark:text-neutral-80/40',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand where I took this from

@marcelines
Copy link
Collaborator

Shouldn't we have this variant in a story? Blur and rendering an icon?

@prichodko
Copy link
Collaborator Author

Shouldn't we have this variant in a story? Blur and rendering an icon?

Should (i.e., blocking?) I don't think so. Good feature to add? For sure.

@prichodko prichodko merged commit a3f9252 into status-im:main Oct 10, 2024
1 of 2 checks passed
@prichodko prichodko deleted the fix-button-blur-icon-color branch October 10, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants