Skip to content

Commit

Permalink
build: update reviewer team and ensure proper newline handling
Browse files Browse the repository at this point in the history
  • Loading branch information
Planeshifter committed Aug 11, 2023
1 parent 0d591da commit 2ad8e5d
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint_random_files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,6 @@ jobs:
labels: |
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers

This comment has been minimized.

Copy link
@kgryte

kgryte Aug 12, 2023

Member

Was this always wrong, or did you rename the team?

This comment has been minimized.

Copy link
@Planeshifter

Planeshifter Aug 12, 2023

Author Member

@kgryte I was wondering the same. Likely it was always wrong. It works now.

This comment has been minimized.

Copy link
@kgryte

kgryte Aug 12, 2023

Member

It's possible I was confused. Thanks for fixing.

branch: 'fix-lint-errors'
delete-branch: true
2 changes: 1 addition & 1 deletion .github/workflows/markdown_equations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:
documentation
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: markdown-insert-equations
delete-branch: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/markdown_tocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
documentation
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-namespace-tocs
delete-branch: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/namespace_declarations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
documentation
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-namespace-declarations
delete-branch: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/namespace_exports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,6 @@ jobs:
labels: |
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-namespace-exports
delete-branch: true
2 changes: 1 addition & 1 deletion .github/workflows/update_contributors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
documentation
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-contributors
delete-branch: true

Expand Down
27 changes: 14 additions & 13 deletions .github/workflows/update_error_databases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ jobs:
node lib/node_modules/@stdlib/error/tools/pkg2id/scripts/build.js
node lib/node_modules/@stdlib/error/tools/id2pkg/scripts/build.js
# Generate Markdown table of added error codes:
- name: 'Generate Markdown table of added error codes'
id: generate-markdown-table
# Generate comment with Markdown table of added error codes:
- name: 'Generate comment body with Markdown table of added error codes'
id: generate-comment-body
run: |
# Get the diff of the CSV file:
git_diff=$(git diff lib/node_modules/@stdlib/error/tools/database/data/data.csv)
Expand Down Expand Up @@ -113,6 +113,15 @@ jobs:
# Assign the table to an output variable:
echo "table=${table}" >> $GITHUB_OUTPUT
# Generate a comment body:
body="This PR\n\n- updates the error databases\n\nThe following error codes were added:\n\n${table}"
# Add the comment body to the workflow output after escaping to preserve newlines:
body="${body//'%'/'%25'}"
body="${body//$'\n'/'%0A'}"
body="${body//$'\r'/'%0D'}"
echo "body=${body}" >> $GITHUB_OUTPUT
# Disable Git hooks:
- name: 'Disable Git hooks'
Expand All @@ -125,22 +134,14 @@ jobs:
uses: peter-evans/create-pull-request@v4
with:
title: 'Update error databases'
body: |
This PR
- updates the error databases
The following error codes were added:
${{ steps.generate-markdown-table.outputs.table }}
body: ${{ steps.generate-comment-body.outputs.body }}
commit-message: 'feat: update error databases'
committer: 'stdlib-bot <[email protected]>'
token: ${{ secrets.PULL_REQUEST_TOKEN }}
labels: |
documentation
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-error-databases
delete-branch: true
2 changes: 1 addition & 1 deletion .github/workflows/update_package_meta_data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
labels: |
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-package-meta-data
delete-branch: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_repl_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
documentation
automated-pr
team-reviewers: |
stdlib-reviewers
reviewers
branch: update-repl-docs
delete-branch: true

Expand Down

0 comments on commit 2ad8e5d

Please sign in to comment.