feat: add C implementation for `math/base/special/ellipe` #1452

gunjjoshi · 2024-03-02T15:50:05Z

Resolves #772

Description

Added C implementation for @stdlib/math/base/special/ellipe.

What is the purpose of this pull request?

This pull request:

adds c implementation for @stdlib/math/base/special/ellipe

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/math/base/special/ellipe #772
a part of [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

☑️ Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

Signed-off-by: GUNJ JOSHI <[email protected]>

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

This reverts commit c52374e.

Signed-off-by: GUNJ JOSHI <[email protected]>

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

Signed-off-by: GUNJ JOSHI <[email protected]>

gunjjoshi · 2024-03-03T06:53:23Z

This is ready for review now. @Pranavchiku

Signed-off-by: GUNJ JOSHI <[email protected]>

lib/node_modules/@stdlib/math/base/special/ellipe/examples/c/example.c

lib/node_modules/@stdlib/math/base/special/ellipe/src/main.c

lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js

kgryte

@gunjjoshi Thanks for working on this. We need to fix the indentation in a few files.

Co-authored-by: Athan <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>

Signed-off-by: GUNJ JOSHI <[email protected]>

gunjjoshi · 2024-03-05T05:13:34Z

@gunjjoshi Thanks for working on this. We need to fix the indentation in a few files.

I have made the changes suggested by you, along with fixing the indentation.

lib/node_modules/@stdlib/math/base/special/ellipe/examples/c/example.c

…xample.c Co-authored-by: Athan <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>

lib/node_modules/@stdlib/math/base/special/ellipe/test/fixtures/cpp/large_negative.json

lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js

kgryte

Thanks for the updates, @gunjjoshi. Left a few more comments.

…es/cpp/large_negative.json` Signed-off-by: GUNJ JOSHI <[email protected]>

…es/cpp/medium_negative.json` Signed-off-by: GUNJ JOSHI <[email protected]>

kgryte

Okay, this now LGTM. Thanks, @gunjjoshi!

Ref: #1452

kgryte · 2024-03-06T12:11:42Z

Just an FYI: I had to push a patch due to bugs introduced in this PR: 89da7ae

For future PRs, be very careful about copying and pasting.

gunjjoshi · 2024-03-06T12:46:08Z

Just an FYI: I had to push a patch due to bugs introduced in this PR: 89da7ae

For future PRs, be very careful about copying and pasting.

Definitely I'll keep that in mind. Apologies for this one. Thanks for correcting this.

Closes: stdlib-js#772 PR-URL: stdlib-js#1452 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Pranav Goswami <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Pranav Goswami <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]> Signed-off-by: Pranav Goswami <[email protected]>

Ref: stdlib-js#1452

gunjjoshi added 2 commits March 2, 2024 21:10

feat: add C implementation for @stdlib/math/base/special/ellipe

fe2d39b

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

feat: add C implementation for @stdlib/math/base/special/ellipe

c417c1e

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

Planeshifter changed the title ~~feat : add C implementation for @stdlib/math/base/special/ellipe~~ feat: add C implementation for @stdlib/math/base/special/ellipe Mar 3, 2024

gunjjoshi added 23 commits March 3, 2024 11:06

Update index.js

b747ddd

Signed-off-by: GUNJ JOSHI <[email protected]>

Update main.js

1265c52

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p1.js

cb4fe80

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p10.js

0292a30

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p11.js

305d517

Signed-off-by: GUNJ JOSHI <[email protected]>

Update README.md

5e596d5

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p12.js

32bec64

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p9.js

7bfad01

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p2.js

c9efb70

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p3.js

b63002f

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p4.js

e6fda42

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p5.js

17b6c55

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p6.js

1722c26

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p7.js

232bf8e

Signed-off-by: GUNJ JOSHI <[email protected]>

Update poly_p8.js

6d9f616

Signed-off-by: GUNJ JOSHI <[email protected]>

feat: add C implementation for @stdlib/math/base/special/ellipe

c52374e

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

Revert "feat: add C implementation for @stdlib/math/base/special/ellipe"

95df2a4

This reverts commit c52374e.

Update evalpoly.js

9ea92bc

Signed-off-by: GUNJ JOSHI <[email protected]>

Merge remote-tracking branch 'origin/ellipe-c' into ellipe-c

f104040

feat: add C implementation for @stdlib/math/base/special/ellipe

7caf789

This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).

Update README.md

aa6b465

Signed-off-by: GUNJ JOSHI <[email protected]>

Update README.md

62dbbe9

Signed-off-by: GUNJ JOSHI <[email protected]>

Update README.md

86be2c1

Signed-off-by: GUNJ JOSHI <[email protected]>

gunjjoshi marked this pull request as draft March 3, 2024 06:38

gunjjoshi marked this pull request as ready for review March 3, 2024 06:51

Update include.gypi

8360e0c

Signed-off-by: GUNJ JOSHI <[email protected]>

Pranavchiku added the Ready To Merge A pull request which is ready to be merged. label Mar 4, 2024

kgryte reviewed Mar 4, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/examples/c/example.c Outdated Show resolved Hide resolved

kgryte reviewed Mar 4, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/src/main.c Outdated Show resolved Hide resolved

kgryte reviewed Mar 4, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/src/main.c Outdated Show resolved Hide resolved

kgryte reviewed Mar 4, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js Outdated Show resolved Hide resolved

kgryte requested changes Mar 4, 2024

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 4, 2024

gunjjoshi and others added 4 commits March 5, 2024 07:01

Update lib/node_modules/@stdlib/math/base/special/ellipe/src/main.c

2421ae5

Co-authored-by: Athan <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>

Update test.native.js

28049f2

Signed-off-by: GUNJ JOSHI <[email protected]>

Update example.c: tab indentation.

0a6ad6b

Signed-off-by: GUNJ JOSHI <[email protected]>

Update main.c: tab indentation.

407bc90

Signed-off-by: GUNJ JOSHI <[email protected]>

kgryte added the Needs Review A pull request which needs code review. label Mar 5, 2024

kgryte reviewed Mar 6, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/examples/c/example.c Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/math/base/special/ellipe/examples/c/e…

6775e65

…xample.c Co-authored-by: Athan <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]>

kgryte reviewed Mar 6, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/test/fixtures/cpp/large_negative.json Outdated Show resolved Hide resolved

kgryte reviewed Mar 6, 2024

View reviewed changes

lib/node_modules/@stdlib/math/base/special/ellipe/test/test.native.js Show resolved Hide resolved

kgryte requested changes Mar 6, 2024

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Mar 6, 2024

gunjjoshi added 2 commits March 6, 2024 16:57

Delete `lib/node_modules/@stdlib/math/base/special/ellipe/test/fixtur…

5d657df

…es/cpp/large_negative.json` Signed-off-by: GUNJ JOSHI <[email protected]>

Delete `lib/node_modules/@stdlib/math/base/special/ellipe/test/fixtur…

002500f

…es/cpp/medium_negative.json` Signed-off-by: GUNJ JOSHI <[email protected]>

kgryte approved these changes Mar 6, 2024

View reviewed changes

kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 6, 2024

kgryte merged commit 23f2db6 into stdlib-js:develop Mar 6, 2024
7 checks passed

kgryte added a commit that referenced this pull request Mar 6, 2024

fix: update polynomial functions and fix function call

89da7ae

Ref: #1452

utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024

fix: update polynomial functions and fix function call

be018c2

Ref: stdlib-js#1452

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add C implementation for `math/base/special/ellipe` #1452

feat: add C implementation for `math/base/special/ellipe` #1452

gunjjoshi commented Mar 2, 2024 •

edited

Loading

gunjjoshi commented Mar 3, 2024

kgryte left a comment

gunjjoshi commented Mar 5, 2024

kgryte left a comment

kgryte left a comment

kgryte commented Mar 6, 2024

gunjjoshi commented Mar 6, 2024

feat: add C implementation for math/base/special/ellipe #1452

feat: add C implementation for math/base/special/ellipe #1452

Conversation

gunjjoshi commented Mar 2, 2024 • edited Loading

Description

Related Issues

Questions

Other

Checklist

gunjjoshi commented Mar 3, 2024

kgryte left a comment

Choose a reason for hiding this comment

gunjjoshi commented Mar 5, 2024

kgryte left a comment

Choose a reason for hiding this comment

kgryte left a comment

Choose a reason for hiding this comment

kgryte commented Mar 6, 2024

gunjjoshi commented Mar 6, 2024

feat: add C implementation for `math/base/special/ellipe` #1452

feat: add C implementation for `math/base/special/ellipe` #1452

gunjjoshi commented Mar 2, 2024 •

edited

Loading