feat: add C implementation for blas/base/ssyr2
#2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
kgryte
reviewed
Sep 21, 2024
| float x[] = { 1.0f, 2.0f, 3.0f }; | ||
| float y[] = { 1.0f, 2.0f, 3.0f }; | ||
|
|
||
| c_ssyr2( 102, 121, 3, 1.0f, x, 1, y, 1, A, 3 ); |
There was a problem hiding this comment.
We should be using the enums from shared. We should not use hardcoded values as those are subject to change.
| const int N = 3; | ||
|
|
||
| // Perform the symmetric rank 2 operation `A = α*x*y^T + α*y*x^T + A`: | ||
| c_ssyr2( 102, 121, N, 1.0f, x, 1, y, 1, A, N ); |
| ], | ||
| "libpath": [], | ||
| "dependencies": [ | ||
| "@stdlib/blas/base/shared" |
There was a problem hiding this comment.
You're missing deps, such as sfill and floorf.
kgryte
added
the
Needs Changes
|
Are you wanting to add the C ndarray API to this PR or to a subsequent PR? |
|
Yes, I will add the C |
|
@aman-095 Ah, right. This PR is blocked wrt adding a C |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2039.
Description
This pull request proposes to add C implementation for
blas/base/ssyr2.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers