-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C ndarray
API and refactor blas/ext/base/zfill
#2962
Conversation
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
@kgryte I'll go ahead and apply the test changes in this PR. |
@headlessNode In the future, we will want to split "mixed" changes across multiple PRs. E.g., adding a new feature with making fixes to tests and documentation. Because of how we perform automatic changelog generation, we rely on commits which do not conflate multiple changes. E.g., if we add a new feature, that triggers a semver minor change in a package, but a doc or test change should only trigger a semver patch. However, if a commit has both new features and patch changes, packages may be inadvertently bumped higher than necessary. |
@kgryte understood. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just a final question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @headlessNode!
@kgryte Heads up. I am getting a failing test due to the change |
Resolves none.
Description
This pull request:
ndarray
API and refactorblas/ext/base/zfill
Related Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers