Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fs/read-ndjson #2969

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

yaswanthkosuru
Copy link
Contributor

Resolves #1074.

Description

his RFC proposes adding a filesystem utility to read a file which is newline-delimited JSON (NDJSON).

Related Issues

#1075

This pull request:

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@yaswanthkosuru yaswanthkosuru changed the title feat: add fs/read-ndjson feat: add fs/read-ndjson Sep 30, 2024
@yaswanthkosuru yaswanthkosuru changed the title feat: add fs/read-ndjson feat: add fs/read-ndjson Sep 30, 2024
@yaswanthkosuru
Copy link
Contributor Author

@Planeshifter ready for initial review!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Oct 1, 2024
@yaswanthkosuru
Copy link
Contributor Author

yaswanthkosuru commented Oct 1, 2024

Should I add these link as ndjson :https://ndjson.org/ in readme. md
I am not sure?

@kgryte
Copy link
Member

kgryte commented Oct 1, 2024

Yes, that would be preferrable.

@yaswanthkosuru
Copy link
Contributor Author

@kgryte Ready for final review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/fs/read-ndjson
2 participants