Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dnansumkbn #2996

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: add C ndarray API and refactor blas/ext/base/dnansumkbn #2996

wants to merge 5 commits into from
+368 −205

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Add sC ndarray API and refactor/cleanup blas/ext/base/dnansumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 9, 2024
@kgryte
Copy link
Member

kgryte commented Oct 19, 2024

@headlessNode The downstream test failure is expected in this PR?

@headlessNode
Copy link
Contributor Author

@kgryte Yes, the dnansum uses dnansumkbn for computing the sum. Should be fixed when dnansum is refactored.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. C Issue involves or relates to C. labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot