Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/dnrm2-wasm #3014

Merged
merged 3 commits into from
Oct 17, 2024
Merged

feat: add blas/base/dnrm2-wasm #3014

merged 3 commits into from
Oct 17, 2024

Conversation

aman-095
Copy link
Member

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request adds wasm support for dnrm2.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 17, 2024
@aman-095 aman-095 marked this pull request as ready for review October 17, 2024 07:46
@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly. labels Oct 17, 2024
@aman-095 aman-095 marked this pull request as draft October 17, 2024 08:17
@aman-095 aman-095 marked this pull request as ready for review October 17, 2024 11:22
kgryte
kgryte approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @aman-095, you may want to review the changes and determine whether any should be ported over to other PRs.

@kgryte kgryte merged commit 4f8bad3 into stdlib-js:develop Oct 17, 2024
10 checks passed
@kgryte kgryte changed the title feat: add wasm support for blas/base/dnrm2-wasm feat: add blas/base/dnrm2-wasm Oct 17, 2024
kgryte pushed a commit that referenced this pull request Oct 18, 2024
@aman-095
docs: fix examples in blas/base/dnrm2-wasm
01e414b 
PR-URL: #3018
Ref: 4f8bad3
Ref: #3014
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. WebAssembly Issue involves or relates to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @kgryte @stdlib-bot