Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting previous extended grapheme cluster break #363

Closed
wants to merge 5 commits into from

Conversation

ShraddheyaS
Copy link
Contributor

@ShraddheyaS ShraddheyaS commented Sep 13, 2020

Resolves #362.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Adds support for getting the previous extended grapheme cluster break in a string before a specified position.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Just as next-grapheme-cluster-break imagines a break at the end of the string (return value str.length), this package imagines a break at the start of the string (return value -1).


@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Sep 13, 2020
@kgryte
Copy link
Member

kgryte commented Sep 14, 2020

This PR has similar concerns as #361 . Based on the resolution of those concerns, this PR may need to be similarly updated.

@ShraddheyaS
Copy link
Contributor Author

Closing as plan to include this auxiliary functionality in the next-grapheme-cluster-break package.

@ShraddheyaS ShraddheyaS closed this Oct 1, 2020
@ShraddheyaS ShraddheyaS deleted the prev branch October 1, 2020 09:35
@ShraddheyaS ShraddheyaS restored the prev branch October 1, 2020 09:35
@kgryte
Copy link
Member

kgryte commented Oct 1, 2020

Sounds good!

Planeshifter added a commit that referenced this pull request Oct 9, 2021
Credit to @ShraddheyaS who created the original pull request this package is based on (#363).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
2 participants