Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature: IntrospectDMMF & IntrospectSDL & migrate push SDK #771

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

AnsonCode
Copy link

Try add 3 feature:

  1. IntrospectDMMF: instrospect database ,get dmmf
  2. IntrospectSDL: instrospect database, get graphql sdl
  3. Migrate Push: expose PUSH SDK to the outside

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ AnsonCode
❌ sx19990201
❌ erguotou520
You have signed the CLA already but the status is still pending? Let us recheck it.

@AnsonCode AnsonCode closed this Sep 23, 2022
@steebchen
Copy link
Owner

steebchen commented Sep 27, 2022

Hey @AnsonCode, thanks for the PR! I'm just going to re-open this PR, just because I think it would be actually nice to have this in the Go client. I think it would need a refactor as I see lots of duplicate code, and I'd put some english comments as well. If there's no time I think it's still good to have this code for reference as when someone wants to add this functionality in the future.

Do you want to keep working on refactoring this to getting it merged eventually?

@steebchen steebchen reopened this Sep 27, 2022
@AnsonCode
Copy link
Author

Hey @AnsonCode, thanks for the PR! I'm just going to re-open this PR, just because I think it would be actually nice to have this in the Go client. I think it would need a refactor as I see lots of duplicate code, and I'd put some english comments as well. If there's no time I think it's still good to have this code for reference as when someone wants to add this functionality in the future.

Do you want to keep working on refactoring this to getting it merged eventually?

Hey @steebchen ,thanks for your attation. I'm going to reconstruct it. And hope it can help others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants